Updated patch to make requested changes, with test suite update. PTAL at
the
one breaking API change described in this note.
https://codereview.chromium.org/467013003/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/467013003/diff/1/include/v8.h#newcode3730
include/v8.h:3730: void SetGenericNamedPropertyHandler(
On 2014/08/13 08:25:39, dcarney (ooto) wrote:
should be SetNamedPropertyHandler. easier to get rid of the old
version that
way.
Alack, I just did this, but:
../test/cctest/test-api.cc: In function 'void
TestGetOwnPropertyNamesWithInterceptor()':
../test/cctest/test-api.cc:9672:64: error: call of overloaded
'SetNamedPropertyHandler(NULL, NULL, NULL, NULL, void (&)(const
v8::PropertyCallbackInfo<v8::Array>&))' is ambiguous
I am thinking that breaking this code is acceptable, though, as Chromium
is unlikely to have code of this form. WDYT?
https://codereview.chromium.org/467013003/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/467013003/diff/1/src/objects.cc#newcode2914
src/objects.cc:2914: (!name->IsString() &&
!interceptor->can_intercept_symbols())) {
On 2014/08/13 08:25:40, dcarney (ooto) wrote:
everywhere else you do
name->IsSymbol() && !interceptor->can_intercept_symbols()
can you please do that here for consistency
Done.
https://codereview.chromium.org/467013003/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/467013003/diff/1/src/objects.h#newcode10850
src/objects.h:10850: inline void set_flags(int flags);
On 2014/08/13 08:25:40, dcarney (ooto) wrote:
can you add a TODO here to remove the flags field when the Generic
interceptors
are renamed?
Done.
https://codereview.chromium.org/467013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
