NOT LGTM
https://codereview.chromium.org/467013003/diff/40001/src/objects.cc
File src/objects.cc (left):
https://codereview.chromium.org/467013003/diff/40001/src/objects.cc#oldcode13612
src/objects.cc:13612: // TODO(rossberg): support symbols in API, and
filter here if needed.
Note that simply relaxing this function to also return symbol names will
break (indirect) use sites. In particular, it is used by
JSReceiver::GetKeys, which in turn is invoked in various places, some of
which are not expecting symbols (e.g., JsonStringifier).
I'm afraid you need to carefully check and adapt all transitive
dependencies (and include respective tests).
https://codereview.chromium.org/467013003/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/467013003/diff/40001/src/objects.cc#newcode4258
src/objects.cc:4258: return Maybe<PropertyAttributes>(ABSENT);
Nit: maybe(ABSENT)
https://codereview.chromium.org/467013003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
