https://codereview.chromium.org/473263004/diff/1/src/compiler/js-context-specialization.h
File src/compiler/js-context-specialization.h (right):
https://codereview.chromium.org/473263004/diff/1/src/compiler/js-context-specialization.h#newcode19
src/compiler/js-context-specialization.h:19: class JSContextSpecializer
{
This class is becoming more general now. I think we should rename this
to JSContextAccessBuilder or something similar.
https://codereview.chromium.org/473263004/diff/1/src/compiler/js-context-specialization.h#newcode22
src/compiler/js-context-specialization.h:22: : specialized_(false),
If you make this a parameter, then you can simplify the pipeline a bit.
It can just always call SpecializeToContext(), which will be a no-op if
the specializer is not figured to do specialization.
https://codereview.chromium.org/473263004/diff/1/src/compiler/js-graph.h
File src/compiler/js-graph.h (right):
https://codereview.chromium.org/473263004/diff/1/src/compiler/js-graph.h#newcode77
src/compiler/js-graph.h:77: MachineType type = kMachAnyTagged) {
This doesn't seem like the right place for this method...I think it's
better to keep it contained to JSContextSpecialization.
https://codereview.chromium.org/473263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
