This pulls out the following changes from the initially proposed CL:
(1) Adding strict mode as a parameter
(2) Have pipeline members to configure inlining and context specialization
These changes are orthogonal to the points still open, which I will land in
another CL for sake of clarity. (cf. patchset 3)
https://codereview.chromium.org/473263004/diff/1/src/compiler/js-graph.h
File src/compiler/js-graph.h (right):
https://codereview.chromium.org/473263004/diff/1/src/compiler/js-graph.h#newcode77
src/compiler/js-graph.h:77: MachineType type = kMachAnyTagged) {
On 2014/08/20 12:54:38, titzer wrote:
This doesn't seem like the right place for this method...I think it's
better to
keep it contained to JSContextSpecialization.
Done.
https://codereview.chromium.org/473263004/diff/100001/tools/run-tests.py
File tools/run-tests.py (right):
https://codereview.chromium.org/473263004/diff/100001/tools/run-tests.py#newcode65
tools/run-tests.py:65: "turbofan-generic": ["--turbo-filter=*",
"--always-opt", "--nocontext-specialization"],
Adds a variant with context specialization disabled. Without this, the
code I'm adding is never considered by already existing unit tests since
context specialization is enabled by default and reverts most of the
changes.
Please advise if this is a good idea. It will not increase the release
checks by much, but possibly the debug checks.
The optimal thing would be to run only tubofan tests with this mode.
https://codereview.chromium.org/473263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
