https://codereview.chromium.org/473263004/diff/170001/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/473263004/diff/170001/src/compiler/ast-graph-builder.cc#newcode902
src/compiler/ast-graph-builder.cc:902:
NewNode(javascript()->StoreNamed(info()->strict_mode(), name),
On 2014/08/27 13:26:18, Michael Starzinger wrote:
nit: Please s/info()->strict_mode()/strict_mode()/ throughout the
file.
Done.
https://codereview.chromium.org/473263004/diff/170001/test/cctest/compiler/function-tester.h
File test/cctest/compiler/function-tester.h (right):
https://codereview.chromium.org/473263004/diff/170001/test/cctest/compiler/function-tester.h#newcode34
test/cctest/compiler/function-tester.h:34: USE(flags_);
On 2014/08/27 13:26:18, Michael Starzinger wrote:
Why do we need this USE here?
The only use is guarded by V8_TURBOFAN_TARGET, so without this use, some
arches won't compile.
https://codereview.chromium.org/473263004/diff/170001/test/cctest/compiler/function-tester.h#newcode49
test/cctest/compiler/function-tester.h:49:
info.MarkAsContextSpecializing();
On 2014/08/27 13:26:18, Michael Starzinger wrote:
If the condition goes over a line-break then please add curly braces.
Done.
https://codereview.chromium.org/473263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
