This conflates two changes, the strict-mode change is non-controversial and
I
would have immediately approved it. The refactoring to the pipeline, I have
my
quarrels with.
https://codereview.chromium.org/473263004/diff/80002/src/compiler/ast-graph-builder.cc
File src/compiler/ast-graph-builder.cc (right):
https://codereview.chromium.org/473263004/diff/80002/src/compiler/ast-graph-builder.cc#newcode902
src/compiler/ast-graph-builder.cc:902:
NewNode(javascript()->StoreNamed(info()->strict_mode(), name),
nit: s/info()->strict_mode()/strict_mode()/ here and at all occurences
below.
https://codereview.chromium.org/473263004/diff/80002/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):
https://codereview.chromium.org/473263004/diff/80002/src/compiler/pipeline.h#newcode55
src/compiler/pipeline.h:55: bool inlining_;
I don't think this should be carried along in the Pipeline, but should
rather be added to the CompilationInfo (if at all). Can you elaborate
why we need this flag? Will it only ever be used for testing?
https://codereview.chromium.org/473263004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
