On 2014/08/27 14:06:40, Michael Starzinger wrote:

https://codereview.chromium.org/473263004/diff/170001/test/cctest/compiler/function-tester.h
File test/cctest/compiler/function-tester.h (right):


https://codereview.chromium.org/473263004/diff/170001/test/cctest/compiler/function-tester.h#newcode34
test/cctest/compiler/function-tester.h:34: USE(flags_);
On 2014/08/27 13:48:49, sigurds wrote:
> On 2014/08/27 13:26:18, Michael Starzinger wrote:
> > Why do we need this USE here?
> The only use is guarded by V8_TURBOFAN_TARGET, so without this use, some
arches
> won't compile.

Acknowledged. Interesting, I didn't know that C-compilers also warn about
unused
fields, good to know.

At least clang does warn if private fields are not used: -Wunused-private-field

https://codereview.chromium.org/473263004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to