A few more tests would be useful to prevent regressions.
https://codereview.chromium.org/663683006/diff/500001/test/mjsunit/es6/templates.js
File test/mjsunit/es6/templates.js (right):
https://codereview.chromium.org/663683006/diff/500001/test/mjsunit/es6/templates.js#newcode38
test/mjsunit/es6/templates.js:38: (function testLineCondition() {
testLineCondition -> testLineContinuation
https://codereview.chromium.org/663683006/diff/500001/test/mjsunit/es6/templates.js#newcode45
test/mjsunit/es6/templates.js:45: var called = false;
Tip: Use a number instead and increment it. Then you also catch wrong
number of calls.
var calls = 0;
(function(s) {
calls++;
})`test`;
assertEquals(1, calls);
https://codereview.chromium.org/663683006/diff/500001/test/mjsunit/es6/templates.js#newcode219
test/mjsunit/es6/templates.js:219: })();
A few more test would not hurt:
1.
I know your code behaves correct here but we should add a few more tests
for strange Array.prototype. For example using setters.
Object.defineProperty(Array.prototype, 0, {
set: function() {
assertUnreachable();
}
});
fn`a${1}b`
2.Can you add tests that the call site object has the correct shape and
is froozen?
3. I don't see a test for \`
4. Maybe a test with a BOM is needed too?
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
