I used git commit --amend to update the commit message and that did not
reflect
here when I next did git cl upload. I had to do git-cl description and
git cl
upload and then it worked.
Oh there's an edit button on the web page that'll work next time.
I just now noticed that I left out one comment of yours. Did you mean to
say
updating variant_ through CPUID is a better way than through
ExtractField()?
Should I change that also?
I'd rather have all CPUs contain valid data for variant_, not just ARM.
CPUID
seems the right way to do it for x86.
Looks good otherwise on my end, but I don't own any V8 code :-)
https://codereview.chromium.org/797233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
