> I just now noticed that I left out one comment of yours. Did you mean
to say
> updating variant_ through CPUID is a better way than through
ExtractField()?
> Should I change that also?
I'd rather have all CPUs contain valid data for variant_, not just ARM.
CPUID
seems the right way to do it for x86.
I'd say variant is ARM-only for now, as there's no need to have it on x86
currently. We can always extend that later when necessary.
https://codereview.chromium.org/797233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
