PTAL
https://codereview.chromium.org/797233002/diff/100001/src/base/cpu.cc
File src/base/cpu.cc (right):
https://codereview.chromium.org/797233002/diff/100001/src/base/cpu.cc#newcode303
src/base/cpu.cc:303: variant_(0),
On 2014/12/19 06:32:09, Benedikt Meurer wrote:
The 0 default is not safe as we would default to denver if there is no
variant
in cpuinfo, please change it back to -1, sorry for the confusion from
my earlier
comment.
Done.
https://codereview.chromium.org/797233002/diff/100001/src/base/cpu.h
File src/base/cpu.h (right):
https://codereview.chromium.org/797233002/diff/100001/src/base/cpu.h#newcode51
src/base/cpu.h:51: static const int NV_VARIANT_DENVER = 0x0;
On 2014/12/19 06:32:09, Benedikt Meurer wrote:
Please rename to NVIDIA_DENVER.
Done.
https://codereview.chromium.org/797233002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
