There's no intent thread yet, just a prototype. If it bumps up from stage 0
I
will submit an intent thread. In the mean time, it didn't take very long to
write, and I'm using it to get a bit more familiar with the compiler
internals,
so it's win/win I think.
About TF coverage, good point.
https://codereview.chromium.org/953563002/diff/40001/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/953563002/diff/40001/src/compiler/typer.cc#newcode1229
src/compiler/typer.cc:1229: return Type::Range(-V8_INFINITY,
+V8_INFINITY, t->zone());
On 2015/02/24 14:09:03, Michael Starzinger wrote:
This is a pretty broad range. :)
I have some ideas for how to make it a bit more narrow, but it's still
going to be [-ε...-1], [ε...1], [-ε...-Infinity], [ε...Infinity] ---
broad range seemed easiest to get working quickly.
https://codereview.chromium.org/953563002/diff/40001/src/compiler/typer.cc#newcode1234
src/compiler/typer.cc:1234: if (lhs->Is(Type::NaN()) ||
rhs->Is(Type::NaN())) return Type::NaN();
On 2015/02/24 14:09:03, Michael Starzinger wrote:
Isn't the exponentiation supposed to perform an implicit ToNumber
conversion (or
something similar)? This doesn't seem to be reflected here.
I might be misunderstanding what the typer is doing. I think I'm
determining a type for the node output, based on the input nodes? Is
there a way to tell the input nodes they need to be converted to numbers
here?
https://codereview.chromium.org/953563002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
