On 2015/02/24 19:36:59, caitp wrote:
On 2015/02/24 19:33:31, Michael Starzinger wrote:
> On 2015/02/24 14:56:13, caitp wrote:
> > There's no intent thread yet, just a prototype. If it bumps up from
stage
0
I
> > will submit an intent thread. In the mean time, it didn't take very
long
to
> > write, and I'm using it to get a bit more familiar with the compiler
> internals,
> > so it's win/win I think.
>
> I am not sure how to interpret this. Does this mean that this CL is not
intended
> to be landed (in let's say the next month)? Am I still supposed to do a
thorough
> review? Also how will I know when this CL is going from "prototype" to
> "implementation"? It's probably just me who is confused at this point.
Actually, I think I was confused --- apparently this proposal has been at
stage
2 since last September (based on
https://github.com/tc39/ecma262/commit/1af3d1e7c24343e6c30bd60bd8b7b0c69ce8bd01),
so this is probably due for an intent thread. The proposal itself was
marked
as
stage 0 until last night
(https://github.com/rwaldron/exponentiation-operator/commit/bffe813e0141a29173ec07862c416642c2cd9fd5).
So I will end up writing an intent thread this week.
My 2 cents:
1. Writing experimental prototype CLs and seeking feedback is fine and
greatly
encouraged as long as those CLs are clearly marked as such.
2. I am not convinced that now is the right time to land exponentiation
operator
in V8:
- we are in time of great churn, what with all the ES6 features and
TurboFan
trying to replace Crankshaft
- you see for yourself that this Cl ends up being pretty invasive and a
moving part on top of a bunch of other moving parts
- it is not that we see a high demand for exponentiation operator being
implemented in V8 at this point
- once this lands, we need to support exp operator throughout any and all
changes and refactorings we need to do. To really get exp operator support
on
par with other arithmetic operators we have, we would need to implement
BinaryOpIC support for it and so on and so forth - I do not think we have
bandwidth at this point to do this.
So my recommendation would be to not land this at this point of time.
https://codereview.chromium.org/953563002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
