Two high-level comments:
1) Why is this being implemented now? Did I miss an "intent to implement"
mail?
This is not on track for ES6, correct?
2) The test coverage for TurboFan is very slim (as in non-existent). We
should
at least make sure to have unit-tests for the operators and the typer as
well as
end-to-end tests in test-run-jsops.
https://codereview.chromium.org/953563002/diff/40001/src/compiler/opcodes.h
File src/compiler/opcodes.h (right):
https://codereview.chromium.org/953563002/diff/40001/src/compiler/opcodes.h#newcode156
src/compiler/opcodes.h:156: V(NumberExponentiate) \
This opcode is never used.
https://codereview.chromium.org/953563002/diff/40001/src/compiler/typer.cc
File src/compiler/typer.cc (right):
https://codereview.chromium.org/953563002/diff/40001/src/compiler/typer.cc#newcode1229
src/compiler/typer.cc:1229: return Type::Range(-V8_INFINITY,
+V8_INFINITY, t->zone());
This is a pretty broad range. :)
https://codereview.chromium.org/953563002/diff/40001/src/compiler/typer.cc#newcode1234
src/compiler/typer.cc:1234: if (lhs->Is(Type::NaN()) ||
rhs->Is(Type::NaN())) return Type::NaN();
Isn't the exponentiation supposed to perform an implicit ToNumber
conversion (or something similar)? This doesn't seem to be reflected
here.
https://codereview.chromium.org/953563002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
