On 2015/02/24 14:56:13, caitp wrote:
There's no intent thread yet, just a prototype. If it bumps up from stage
0 I
will submit an intent thread. In the mean time, it didn't take very long
to
write, and I'm using it to get a bit more familiar with the compiler
internals,
so it's win/win I think.
I am not sure how to interpret this. Does this mean that this CL is not
intended
to be landed (in let's say the next month)? Am I still supposed to do a
thorough
review? Also how will I know when this CL is going from "prototype" to
"implementation"? It's probably just me who is confused at this point.
https://codereview.chromium.org/953563002/diff/40001/src/compiler/typer.cc#newcode1234
src/compiler/typer.cc:1234: if (lhs->Is(Type::NaN()) ||
rhs->Is(Type::NaN()))
return Type::NaN();
On 2015/02/24 14:09:03, Michael Starzinger wrote:
> Isn't the exponentiation supposed to perform an implicit ToNumber
conversion
(or
> something similar)? This doesn't seem to be reflected here.
I might be misunderstanding what the typer is doing. I think I'm
determining a
type for the node output, based on the input nodes? Is there a way to
tell the
input nodes they need to be converted to numbers here?
Yes, the typer should type a "JSExponentiate" operation here. But since this
operation is of the "JS" flavor and hence performs implicit type
conversion, the
typer needs to treat e.g. an operand of "undefined" as "NaN" here. This
would be
done by the Typer::Visitor::ToNumber helper.
https://codereview.chromium.org/953563002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
