Andreas, I noticed that tests/mjsunit/samevalue.js does not test
SameValueZero,
so I modified the tests. It seems to belong in the same file, since they
are so
similar.
Let me know if you'd like me to split this into its own CL. Otherwise, I'll
update the issue description to include this change.
PTAL
https://codereview.chromium.org/1219943002/diff/250001/src/arm64/full-codegen-arm64.cc
File src/arm64/full-codegen-arm64.cc (right):
https://codereview.chromium.org/1219943002/diff/250001/src/arm64/full-codegen-arm64.cc#newcode4894
src/arm64/full-codegen-arm64.cc:4894:
ASM_LOCATION("FullCodeGenerator::EmitLiteralCompareTypeof
symbol_string");
On 2015/07/09 10:48:07, martyn.capewell wrote:
DBC: s/symbol_string/float32x4_string/
Thanks for catching this. Fixed.
https://codereview.chromium.org/1219943002/diff/250001/src/runtime.js
File src/runtime.js (right):
https://codereview.chromium.org/1219943002/diff/250001/src/runtime.js#newcode953
src/runtime.js:953: function SameValue(x, y) {
On 2015/07/10 11:38:20, rossberg wrote:
This also needs to be extended, see the SIMD spec. Affects Object.is
on SIMD
values.
Done.
https://codereview.chromium.org/1219943002/diff/250001/src/runtime.js#newcode967
src/runtime.js:967: function SameValueZero(x, y) {
On 2015/07/10 11:38:20, rossberg wrote:
Likewise. Affects maps/sets over SIMD values as keys.
Done.
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
