https://codereview.chromium.org/1219943002/diff/210001/test/mjsunit/object-toprimitive.js
File test/mjsunit/object-toprimitive.js (right):
https://codereview.chromium.org/1219943002/diff/210001/test/mjsunit/object-toprimitive.js#newcode28
test/mjsunit/object-toprimitive.js:28: // Flags: --harmony-simd
On 2015/07/10 13:21:17, bbudge wrote:
On 2015/07/10 11:38:20, rossberg wrote:
> If this test does not use SIMDs then this flag should not be needed.
If the
test
> nevertheless fails without setting the flag, then that's a (serious)
bug. You
> are probably missing places where you need to make code paths
dependent on the
> flag.
I don't understand the comment. This test does add a test for
SIMD.float32x4,
below. Do you think I should remove this test, or make it conditional
on SIMD
being defined?
Ah, sorry, I somehow got lost in the diffs. Please ignore this comment
and the other one. :)
https://codereview.chromium.org/1219943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
