Looks pretty good to me. A couple of comments.
https://codereview.chromium.org/1230753004/diff/120001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1230753004/diff/120001/src/heap/heap.h#newcode1684
src/heap/heap.h:1684: PretenureFlag pretenure = NOT_TENURED);
Since this should always be TENURED let's remove the PretenureFlag from
here too and just always allocate in the OLD space in the
implementation.
https://codereview.chromium.org/1230753004/diff/120001/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (left):
https://codereview.chromium.org/1230753004/diff/120001/src/interpreter/interpreter.cc#oldcode47
src/interpreter/interpreter.cc:47: // argument.
Did you mean to drop this comment?
https://codereview.chromium.org/1230753004/diff/120001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1230753004/diff/120001/src/objects.cc#newcode11803
src/objects.cc:11803: << static_cast<interpreter::Bytecode>(bc) << "\n";
We will need to do something more complex than this (probably in
Bytecodes.cc) to deal with bytecode arguments and such, but this is
probably fine for now.
https://codereview.chromium.org/1230753004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
