Generally looks good to me with a few more comments.
Ulan: could you take a look and let us know if we've missed anything that
needs
to be added for a new object type?
https://codereview.chromium.org/1230753004/diff/200001/src/heap/heap.h
File src/heap/heap.h (right):
https://codereview.chromium.org/1230753004/diff/200001/src/heap/heap.h#newcode1685
src/heap/heap.h:1685:
nit - drop extra newline
https://codereview.chromium.org/1230753004/diff/200001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/1230753004/diff/200001/src/objects-inl.h#newcode3657
src/objects-inl.h:3657: return READ_INT_FIELD(this, kFrameSizeOffset);
These should be stored as SMI values. Could you just use the
SMI_ACCESSORS macro?
https://codereview.chromium.org/1230753004/diff/200001/src/objects-printer.cc
File src/objects-printer.cc (right):
https://codereview.chromium.org/1230753004/diff/200001/src/objects-printer.cc#newcode206
src/objects-printer.cc:206: os << buf.start();
nit - do you need to change this function?
https://codereview.chromium.org/1230753004/diff/200001/src/objects-printer.cc#newcode214
src/objects-printer.cc:214: os << buf.start();
I don't think these lines is necessary - it should be clear from
Dissasemble which prints the addresses of the bytecodes as it prints
them.
https://codereview.chromium.org/1230753004/diff/200001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/1230753004/diff/200001/src/objects.cc#newcode11801
src/objects.cc:11801: int bytecode_size = 0;
Could you print out frame size / locals count here too please. Also
start with some header showing this is a Bytecode array being printed.
https://codereview.chromium.org/1230753004/diff/200001/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/1230753004/diff/200001/src/objects.h#newcode4277
src/objects.h:4277: // Accessors for frame size and offsets
/s/offsets/locals count./
https://codereview.chromium.org/1230753004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
