Looks good here. One minor comment about template use.
https://codereview.chromium.org/1309843007/diff/20001/src/interpreter/bytecode-array-builder.cc
File src/interpreter/bytecode-array-builder.cc (right):
https://codereview.chromium.org/1309843007/diff/20001/src/interpreter/bytecode-array-builder.cc#newcode303
src/interpreter/bytecode-array-builder.cc:303: bool
BytecodeArrayBuilder::FitsByteOperand(T value) {
Template seems a bit gratuitous here - it's invoked with value being
size_t or int. For template, is_integral would clarify things.
FitsInByteOperand? ValueFitsInByteOperand?
https://codereview.chromium.org/1309843007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
