https://codereview.chromium.org/1309843007/diff/20001/src/interpreter/bytecode-array-builder.cc
File src/interpreter/bytecode-array-builder.cc (right):
https://codereview.chromium.org/1309843007/diff/20001/src/interpreter/bytecode-array-builder.cc#newcode303
src/interpreter/bytecode-array-builder.cc:303: bool
BytecodeArrayBuilder::FitsByteOperand(T value) {
On 2015/09/01 14:01:54, oth wrote:
Template seems a bit gratuitous here - it's invoked with value being
size_t or
int. For template, is_integral would clarify things.
FitsInByteOperand? ValueFitsInByteOperand?
Ahh, is_integral is exactly what I wanted, thanks. Changed to
FitsInByteOperand
https://codereview.chromium.org/1309843007/diff/20001/test/cctest/interpreter/test-bytecode-generator.cc
File test/cctest/interpreter/test-bytecode-generator.cc (right):
https://codereview.chromium.org/1309843007/diff/20001/test/cctest/interpreter/test-bytecode-generator.cc#newcode342
test/cctest/interpreter/test-bytecode-generator.cc:342:
ExpectedSnippet<const char*> snippets[] = {
On 2015/09/01 14:28:29, mvstanton wrote:
Nice test! Helps to explain what is happening...
Acknowledged.
https://codereview.chromium.org/1309843007/diff/40001/src/compiler/interpreter-assembler.cc
File src/compiler/interpreter-assembler.cc (right):
https://codereview.chromium.org/1309843007/diff/40001/src/compiler/interpreter-assembler.cc#newcode239
src/compiler/interpreter-assembler.cc:239: Node*
InterpreterAssembler::CallIC(CallInterfaceDescriptor descriptor,
On 2015/09/01 14:28:29, mvstanton wrote:
If the number of arguments are going to be fixed I'd like to see
something in
the name calling it a LoadIC, since StoreIC and other types of ICs may
have
different numbers of arguments.
Maybe an ic_kind (Code::LOAD_IC, etc.) parameter could be passed?
My plan was to have overloads for the number of parameters once we need
other CallICs with a different number of arguments (similar to
CallJSBuiltin below). I didn't want to make these specific to a
particular IC type, this is really just meant to be a low-level operator
which calls the given descriptor with the given arguments. WDYT?
https://codereview.chromium.org/1309843007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
