Looking good, just one issue about evaluation order.
https://codereview.chromium.org/1309843007/diff/60001/src/interpreter/bytecode-generator.cc
File src/interpreter/bytecode-generator.cc (right):
https://codereview.chromium.org/1309843007/diff/60001/src/interpreter/bytecode-generator.cc#newcode318
src/interpreter/bytecode-generator.cc:318: Visit(expr->obj());
The JavaScript evaluation order is first to evaluate the object and then
evaluate the key. That is observable with e.g. ...
(o.something_that_prints())[o.something_that_throws()];
https://codereview.chromium.org/1309843007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
