still lgtm
https://codereview.chromium.org/1309843007/diff/40001/src/compiler/interpreter-assembler.cc
File src/compiler/interpreter-assembler.cc (right):
https://codereview.chromium.org/1309843007/diff/40001/src/compiler/interpreter-assembler.cc#newcode239
src/compiler/interpreter-assembler.cc:239: Node*
InterpreterAssembler::CallIC(CallInterfaceDescriptor descriptor,
On 2015/09/01 15:53:36, rmcilroy wrote:
On 2015/09/01 14:28:29, mvstanton wrote:
> If the number of arguments are going to be fixed I'd like to see
something in
> the name calling it a LoadIC, since StoreIC and other types of ICs
may have
> different numbers of arguments.
>
> Maybe an ic_kind (Code::LOAD_IC, etc.) parameter could be passed?
My plan was to have overloads for the number of parameters once we
need other
CallICs with a different number of arguments (similar to CallJSBuiltin
below). I
didn't want to make these specific to a particular IC type, this is
really just
meant to be a low-level operator which calls the given descriptor with
the given
arguments. WDYT?
Okay I can live with that :).
https://codereview.chromium.org/1309843007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
