Vector lgtm, a couple of comments - love the tests.
https://codereview.chromium.org/1309843007/diff/20001/test/cctest/interpreter/test-bytecode-generator.cc
File test/cctest/interpreter/test-bytecode-generator.cc (right):
https://codereview.chromium.org/1309843007/diff/20001/test/cctest/interpreter/test-bytecode-generator.cc#newcode342
test/cctest/interpreter/test-bytecode-generator.cc:342:
ExpectedSnippet<const char*> snippets[] = {
Nice test! Helps to explain what is happening...
https://codereview.chromium.org/1309843007/diff/40001/src/compiler/interpreter-assembler.cc
File src/compiler/interpreter-assembler.cc (right):
https://codereview.chromium.org/1309843007/diff/40001/src/compiler/interpreter-assembler.cc#newcode239
src/compiler/interpreter-assembler.cc:239: Node*
InterpreterAssembler::CallIC(CallInterfaceDescriptor descriptor,
If the number of arguments are going to be fixed I'd like to see
something in the name calling it a LoadIC, since StoreIC and other types
of ICs may have different numbers of arguments.
Maybe an ic_kind (Code::LOAD_IC, etc.) parameter could be passed?
https://codereview.chromium.org/1309843007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
