http://codereview.chromium.org/7379004/diff/16/src/platform.h File src/platform.h (right):
http://codereview.chromium.org/7379004/diff/16/src/platform.h#newcode212 src/platform.h:212: // Get the Alignment guaranteed by Allocate(). On 2011/07/15 11:59:14, Vyacheslav Egorov wrote:
empty line between declaration and comment.
Done. http://codereview.chromium.org/7379004/diff/16/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7379004/diff/16/src/spaces.cc#newcode384 src/spaces.cc:384: OS::Guard(mem, Page::kPageSize); On 2011/07/15 11:59:14, Vyacheslav Egorov wrote:
You have decreased kPagesPerChunk for all spaces but you only use it
when you
allocate executable memory.
I think this is still a bit low level and you need to move one level
up and put
guard page management there.
Done. http://codereview.chromium.org/7379004/diff/16/src/spaces.cc#newcode386 src/spaces.cc:386: mem = static_cast<char*>(mem) + Page::kPageSize; On 2011/07/15 11:59:14, Vyacheslav Egorov wrote:
we use Address type instead of char* in such cases.
Done. http://codereview.chromium.org/7379004/diff/16/src/spaces.cc#newcode414 src/spaces.cc:414: OS::Free(static_cast<char*>(mem) - guardsize, length + guardsize); On 2011/07/15 11:59:14, Vyacheslav Egorov wrote:
we use Address type instead of char* in such cases.
Done. http://codereview.chromium.org/7379004/diff/16/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/7379004/diff/16/src/spaces.h#newcode650 src/spaces.h:650: static const int kPagesPerChunkLog2 = 5; On 2011/07/15 11:59:14, Vyacheslav Egorov wrote:
1 << kPagesPerChunkLog2 no longer equals to kPagesPerChunk
I find this disturbing.
Never fear.. This isn't used anywhere so I got rid of it. http://codereview.chromium.org/7379004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
