On Wed, Jul 20, 2011 at 12:24 AM, <[email protected]> wrote: > LGTM. There is one more off by one. I'll take care of that and land. >
Thanks, Mads! Always a pleasure to work with you :) Any chance you could land http://codereview.chromium.org/7377008/ as well, if you like it? It adds good mapping randomization for Linux, both 32-bit and 64-bit (thus closing v8 bug 805). Ideally, we'd also like that landed in time for M14 (as well as the guard pages). Cheers Chris > > > http://codereview.chromium.**org/7379004/diff/27001/src/**spaces.cc<http://codereview.chromium.org/7379004/diff/27001/src/spaces.cc> > > File src/spaces.cc (right): > > http://codereview.chromium.**org/7379004/diff/27001/src/** > spaces.cc#newcode513<http://codereview.chromium.org/7379004/diff/27001/src/spaces.cc#newcode513> > src/spaces.cc:513: kPagesPerChunk - ((guardsize ? 1 : 0) + 1)); > Now that you have move the fiddling with the chunk pointer and the chunk > size to after the conditions you should not change the conditions at > all. I think it is off by a page in the other direction now. > > > http://codereview.chromium.**org/7379004/<http://codereview.chromium.org/7379004/> > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
