Getting there.
http://codereview.chromium.org/7379004/diff/21002/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7379004/diff/21002/src/spaces.cc#newcode518 src/spaces.cc:518: ASSERT(*allocated_pages >= kPagesPerChunk - 1); Will this actually work? What if we lose a page due to alignment and lose a page because of the guard page? We could do all the checking here in exactly the same way that we did before. Then move the guarding to after the if below and subtract one page from allocate_pages if EXECUTABLE? That would also remove the "+/- guardsize" in FreeRawMemory below. http://codereview.chromium.org/7379004/diff/21002/src/spaces.cc#newcode2701 src/spaces.cc:2701: static_cast<Address>(mem) - guardsize, size + guardsize, executable); This looks wrong. You should use mem and size directly as you got them from AllocateRawMemory. http://codereview.chromium.org/7379004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
