we are almost there I think
I am redirecting the last review (and landing) to Mads Ager as I am on
vacation
next week.
http://codereview.chromium.org/7379004/diff/16/src/platform.h
File src/platform.h (right):
http://codereview.chromium.org/7379004/diff/16/src/platform.h#newcode212
src/platform.h:212: // Get the Alignment guaranteed by Allocate().
empty line between declaration and comment.
http://codereview.chromium.org/7379004/diff/16/src/spaces.cc
File src/spaces.cc (right):
http://codereview.chromium.org/7379004/diff/16/src/spaces.cc#newcode384
src/spaces.cc:384: OS::Guard(mem, Page::kPageSize);
You have decreased kPagesPerChunk for all spaces but you only use it
when you allocate executable memory.
I think this is still a bit low level and you need to move one level up
and put guard page management there.
http://codereview.chromium.org/7379004/diff/16/src/spaces.cc#newcode386
src/spaces.cc:386: mem = static_cast<char*>(mem) + Page::kPageSize;
we use Address type instead of char* in such cases.
http://codereview.chromium.org/7379004/diff/16/src/spaces.cc#newcode414
src/spaces.cc:414: OS::Free(static_cast<char*>(mem) - guardsize, length
+ guardsize);
we use Address type instead of char* in such cases.
http://codereview.chromium.org/7379004/diff/16/src/spaces.h
File src/spaces.h (right):
http://codereview.chromium.org/7379004/diff/16/src/spaces.h#newcode650
src/spaces.h:650: static const int kPagesPerChunkLog2 = 5;
1 << kPagesPerChunkLog2 no longer equals to kPagesPerChunk
I find this disturbing.
http://codereview.chromium.org/7379004/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
