LGTM. There is one more off by one. I'll take care of that and land.
http://codereview.chromium.org/7379004/diff/27001/src/spaces.cc File src/spaces.cc (right): http://codereview.chromium.org/7379004/diff/27001/src/spaces.cc#newcode513 src/spaces.cc:513: kPagesPerChunk - ((guardsize ? 1 : 0) + 1)); Now that you have move the fiddling with the chunk pointer and the chunk size to after the conditions you should not change the conditions at all. I think it is off by a page in the other direction now. http://codereview.chromium.org/7379004/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
