feedback address.
http://codereview.chromium.org/7527001/diff/12001/src/elements.cc File src/elements.cc (right): http://codereview.chromium.org/7527001/diff/12001/src/elements.cc#newcode45 src/elements.cc:45: // public ElementsHandlerImpl<SomeElementsHandlerImpl> { On 2011/07/30 10:29:21, jkummerow wrote:
nit: second template argument (BackingStoreClass) is missing in this
example. Done. http://codereview.chromium.org/7527001/diff/12001/src/elements.cc#newcode87 src/elements.cc:87: : public ElementsHandlerImpl< FastElementsHandlerImpl, FixedArray> { On 2011/07/30 10:29:21, jkummerow wrote:
nit: extra space
Done. http://codereview.chromium.org/7527001/diff/12001/src/elements.cc#newcode250 src/elements.cc:250: struct ConcreteElementHandlers { On 2011/07/30 10:29:21, jkummerow wrote:
nit: for consistency, change order to match elements_handler_table_?
(I.e. move
up "dictionary" and "non_strict_arguments".)
Done. http://codereview.chromium.org/7527001/diff/12001/src/objects.cc File src/objects.cc (right): http://codereview.chromium.org/7527001/diff/12001/src/objects.cc#newcode8949 src/objects.cc:8949: #if 0 On 2011/07/30 10:29:21, jkummerow wrote:
nit: If we don't need this code anymore, remove it.
Done. http://codereview.chromium.org/7527001/diff/12001/src/objects.h File src/objects.h (right): http://codereview.chromium.org/7527001/diff/12001/src/objects.h#newcode2024 src/objects.h:2024: // MaybeObject* GetElementPostInterceptor(Object* receiver, uint32_t index); On 2011/07/30 10:29:21, jkummerow wrote:
nit: remove the line instead of commenting it out.
Done. http://codereview.chromium.org/7527001/diff/12001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/7527001/diff/12001/tools/gyp/v8.gyp#newcode491 tools/gyp/v8.gyp:491: '../../src/elements.cc', On 2011/07/30 10:29:21, jkummerow wrote:
Should add elements.h here as well.
Done. http://codereview.chromium.org/7527001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
