My high level comment is the same as Lasse's: I think there is one too many
levels of indirection. It should be possible to roll the ...Impl class
into the
ElementHandlers themselves.
You could also make the handler singletons static members of ElementHandler
instead of in a struct on the side (somewhat like we have StackFrame
singletons
in the StackFrameIterator).
http://codereview.chromium.org/7527001/diff/15002/src/elements.h
File src/elements.h (right):
http://codereview.chromium.org/7527001/diff/15002/src/elements.h#newcode48
src/elements.h:48: inline static ElementsHandler*
ForKind(JSObject::ElementsKind elements_kind) {
No need for 'inline'. Maybe the function name/signature should be
something like SingletonFor(JSObject::ElementsKind).
http://codereview.chromium.org/7527001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
