LGTM, I like the approach, although it is quite different from what we do
elsewhere in the V8 code-base. Adding Lasse as reviewer as well, he has a
small
thing for templates :-)
http://codereview.chromium.org/7527001/diff/15002/src/elements.cc
File src/elements.cc (right):
http://codereview.chromium.org/7527001/diff/15002/src/elements.cc#newcode180
src/elements.cc:180: inline static bool GetNumberDictionaryElement(
Do we use this function outside this class, otherwise just make it
private?
http://codereview.chromium.org/7527001/diff/15002/src/elements.h
File src/elements.h (right):
http://codereview.chromium.org/7527001/diff/15002/src/elements.h#newcode36
src/elements.h:36: // Abstract base class for handles that can operate
on object with differing
on object -> an object or objects
http://codereview.chromium.org/7527001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
