http://codereview.chromium.org/7527001/diff/15002/src/elements.h
File src/elements.h (right):

http://codereview.chromium.org/7527001/diff/15002/src/elements.h#newcode48
src/elements.h:48: inline static ElementsHandler*
ForKind(JSObject::ElementsKind elements_kind) {
We should probably not call it anything with "Singleton", since that's a
less general (anti-)pattern (and we don't implement each class as a
Singleton class - which is a good thing!).
This is more like an object-based enum (q.v. the Java enums, where,
incidentally, "enum Foo" is implemented internally as "class Foo extends
Enum<Foo>" :)

http://codereview.chromium.org/7527001/

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to