Point-comment only. I haven't checked the code yet, only read the responses
(but
those seem good to me :).
http://codereview.chromium.org/7527001/diff/15002/src/objects-inl.h
File src/objects-inl.h (right):
http://codereview.chromium.org/7527001/diff/15002/src/objects-inl.h#newcode1680
src/objects-inl.h:1680: return is_the_hole_nan(READ_DOUBLE_FIELD(this,
offset));
I don't think that helps, since objects are pointer-aligned (v8globals.h
declare kObjectAlignment to be equal to kPointerSize).
It didn't pay off to align HeapNumbers, but it might for arrays of them.
I.e., perhaps insert a one-word-filler before an unaligned double-array.
But that would also require GC to preserve alignment, so it's probably
not a simple fix.
http://codereview.chromium.org/7527001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
