On Thu, Jun 6, 2013 at 1:33 PM, Sven Panne <[email protected]> wrote:
On Thu, Jun 6, 2013 at 11:30 AM, <[email protected]> wrote:
Then is this not a more fundamental problem with how PropertyCallbackInfo
and
AccessorInfo are declared. Wouldn't adding internal versions of them be
more
consistent with the way other types are declared?
https://codereview.chromium.org/16286016/
This was my thought, too. Furthermore, I don't really like
ExternalReference::ICUtilityType, this is an even stronger hint that we
are
doing something wrong IMHO.
I could change the code so that InvokeAccessorGetter{Callback} are declared
using DECLARE_RUNTIME_FUNCTION macro and have same signature as the rest
external calls from generated inline caches. This would require changing
arch-specific call sites and the arguments for the external callback would
be
prepared inside InvokeAccessorGetter{Callback} instead of the generated
code (we
would basically need to prepare PropertyCallbackArguments like it's done for
slow case in objetcs.cc). My main concern here is performance but that would
make the new code more aligned with current native calls from generated ICs
and
would eliminate need for ExternalReference::ICUtilityType. This would not
resolve the issue with using external types though as we would still need to
pass and call v8::AccessorGetter which doesn't have corresponding internal
type.
https://codereview.chromium.org/16286016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
