On 2013/06/06 09:30:57, danno wrote:
Then is this not a more fundamental problem with how PropertyCallbackInfo
and
AccessorInfo are declared. Wouldn't adding internal versions of them be
more
consistent with the way other types are declared?
I could add v8::internal::AccessorInfo, v8::internal::PropertyCallbackInfo,
v8::internal::AccessorGetter and v8::internal::AccessorGetterCallback and
have
corresponding public classes call into the internal ones doing all the
conversion but it would cost us one more function call for each accessor
compared to what we have at the moment(because all non-template methods on
PropertyCallbackInfo would have to be moved into api.cc to be able to work
with
internal types), does that performance penalty sounds ok? If so I can
update the
CL.
https://codereview.chromium.org/16286016/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
