Can you add a test for this?
done
https://codereview.chromium.org/52643002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/52643002/diff/1/src/heap-snapshot-generator.cc#newcode1382
src/heap-snapshot-generator.cc:1382: shared->inferred_name();
DebugName should already return inferred_name if there is no name.
done
https://codereview.chromium.org/52643002/diff/1/src/heap-snapshot-generator.cc#newcode1481
src/heap-snapshot-generator.cc:1481:
CodeStub::MajorName(static_cast<CodeStub::Major>(code->major_key()),
Please use CodeStub::GetName() instead, it would give more details.
There is no way to get a pointer to a CodeStub object from Code object.
The common pattern for CodeStubs is to instantiate a CodeStub object,
force them to create the corresponding Code object and destroy the CodeStub
object.
https://codereview.chromium.org/52643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
