comments addressed
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1375
src/heap-snapshot-generator.cc:1375: Object* shared_name =
shared->DebugName();
On 2013/10/31 12:55:46, alph wrote:
nit: DebugName returns String, so you should not need a type cast at
1378.
Done.
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1382
src/heap-snapshot-generator.cc:1382:
Code::Kind2String(shared->code()->kind())));
On 2013/10/31 14:24:02, Yury Semikhatsky wrote:
style: indent 4 characters
Done.
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1476
src/heap-snapshot-generator.cc:1476: case Code::STUB: {
On 2013/10/31 14:24:02, Yury Semikhatsky wrote:
if (code->kind() == Code::STUB) { would be more concise.
Done.
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1476
src/heap-snapshot-generator.cc:1476: case Code::STUB: {
On 2013/10/31 14:28:38, alph wrote:
On 2013/10/31 14:24:02, Yury Semikhatsky wrote:
> if (code->kind() == Code::STUB) { would be more concise.
... and make the function overloaded ;-)
Done.
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1772
src/heap-snapshot-generator.cc:1772: &&
all_references_[all_index]->IsCode()) {
On 2013/10/31 14:24:02, Yury Semikhatsky wrote:
This should always be a code. But we can leave this check to be on the
safe
side.
I'll make ASSERT(all_references_[all_index]->IsCode())
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1774
src/heap-snapshot-generator.cc:1774: builtins->name(all_index -
prev_tag_index));
On 2013/10/31 14:24:02, Yury Semikhatsky wrote:
Can we replace this prev_tag_index with builtin_index and use it here
instead?
...
if (all_references_[all_index]->IsCode()) {
explorer->TagCodeObject(Code::cast(all_references_[all_index]),
builtins->name(builtin_index));
}
builtin_index++;
...
Done.
https://codereview.chromium.org/52643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
