lgtm
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1375
src/heap-snapshot-generator.cc:1375: Object* shared_name =
shared->DebugName();
nit: DebugName returns String, so you should not need a type cast at
1378.
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1758
src/heap-snapshot-generator.cc:1758: int strong_index = 0, all_index =
0, tags_index = 0, prev_tag_index = 0;
maybe prev_tag_index -> tag_first_index ?
https://codereview.chromium.org/52643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
