https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/52643002/diff/190001/src/heap-snapshot-generator.cc#newcode1777
src/heap-snapshot-generator.cc:1777: if
(reference_tags_[tags_index].index == all_index) {
On 2013/10/31 14:24:02, Yury Semikhatsky wrote:
As discussed offline this should be
while (reference_tags_[tags_index].index == all_index) ++tags_index;
to work correctly in case there are empty groups. This can be
addressed
separately though with a separate test.
On the second look the current implementation is correct as the tags for
empty groups will be skipped in RootsReferencesExtractor::Synchronize
https://codereview.chromium.org/52643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
