comments addressed
https://codereview.chromium.org/52643002/diff/100001/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/52643002/diff/100001/src/heap-snapshot-generator.cc#newcode1377
src/heap-snapshot-generator.cc:1377: shared_name = (shared_name !=
empty_string) ?
On 2013/10/31 11:42:34, alph wrote:
Doesn't DebugName already have the semantics you're implementing here?
done
https://codereview.chromium.org/52643002/diff/100001/src/heap-snapshot-generator.cc#newcode1472
src/heap-snapshot-generator.cc:1472: void
V8HeapExplorer::TagCodeObject(Code* code, const char* external_name) {
On 2013/10/31 11:42:34, alph wrote:
nit: looks like having an overload here is more appropriate. wdyt?
I don't think that we need additional function here.
https://codereview.chromium.org/52643002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
