https://codereview.chromium.org/284153004/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/284153004/diff/1/src/ic.cc#newcode866
src/ic.cc:866: set_target(*pre_monomorphic_stub(), SKIP_ICACHE_FLUSH);
I am not sure whether this is safe. We are leaving icache in an
inconsistent state. Do ARM, ARM64, MIPS guarantee some kind of
"atomicity" in this case? I mean
1) either the old instruction is completely executed
2) or the new instruction is completely executed?
https://codereview.chromium.org/284153004/diff/1/src/ic.cc#newcode1320
src/ic.cc:1320: set_target(*stub, SKIP_ICACHE_FLUSH);
ditto
https://codereview.chromium.org/284153004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
