Updated to remove skipping during IC updates as discussed offline. Also added
other architectures and updated the CL description.  PTAL.

If you only apply this change to CopyFrom then maybe a scope would make things simpler: outside the scope flush, inside skip, no update is required to the
function definitions.

I thought of this, however it's not easy to do since set_target_address_at is
static, so there is nothing which we can figure out whether we are inside or
outside the scope except for an argument anyway.


https://codereview.chromium.org/284153004/diff/40001/src/arm/assembler-arm-inl.h
File src/arm/assembler-arm-inl.h (right):

https://codereview.chromium.org/284153004/diff/40001/src/arm/assembler-arm-inl.h#newcode513
src/arm/assembler-arm-inl.h:513: static uint32_t
ExtractMovwImmediate(Instr instruction) {
On 2014/05/19 12:38:38, Rodolph Perfetta wrote:
the Instruction class has a ImmedMovwMovtValue method which will do
this.

Ack (no longer applicable).

https://codereview.chromium.org/284153004/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to