On 2014/05/16 16:31:56, Rodolph Perfetta (ARM) wrote:
https://codereview.chromium.org/284153004/diff/20001/src/arm/assembler-arm-inl.h
File src/arm/assembler-arm-inl.h (right):
https://codereview.chromium.org/284153004/diff/20001/src/arm/assembler-arm-inl.h#newcode543
src/arm/assembler-arm-inl.h:543: MemoryBarrier();
> How about if we only need to update one of the instructions then? It is
likely
> that the MovT probably doesn't need to be updated for most IC cache
updates,
so
> we can maybe get away with this if only the MovW needs updated - is
there
> anything else I would need to do if I was only updating a single
instruction?
No nothing else, that should work. Though if one day V8 were to do
concurrent
patching then it won't work anymore.
Updated to only skip if a single instruction as discussed. PTAL.
https://codereview.chromium.org/284153004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
