https://codereview.chromium.org/213943002/diff/80001/src/arm64/simulator-arm64.h
File src/arm64/simulator-arm64.h (right):
https://codereview.chromium.org/213943002/diff/80001/src/arm64/simulator-arm64.h#newcode152
src/arm64/simulator-arm64.h:152: value_ = new_value;
A ternary is a bit more readable here:
value_ = (size == kWRegSizeInBits) ? (new_value & kWRegMask) :
new_value;
https://codereview.chromium.org/213943002/diff/80001/src/arm64/simulator-arm64.h#newcode160
src/arm64/simulator-arm64.h:160: void Set(T new_value) {
This method and the corresponding templatized Get is temporary only,
right? Or is it the other way round? I don't fully understand the
direction we're going here...
https://codereview.chromium.org/213943002/diff/80001/src/arm64/simulator-arm64.h#newcode169
src/arm64/simulator-arm64.h:169: int64_t result = value_;
I think a ternary is more readable here, too:
return (size == kSRegSizeInBits) ? (value_ & kSRegMask) : value;
Furthermore, why do we use kSRegSizeInBits here and not kWRegSizeInBits
(see Set). Granted, they have to be the same, but we somehow should do
things consistently.
https://codereview.chromium.org/213943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
