Re: Direction
A little more info.
The main reason I was trying to get a Set/Get without specifying a size was
to
get around the possibility of compiler issues that came about previously
(https://codereview.chromium.org/203263017/).
I was hoping to be able to eventually templatize the Visit* functions so
that
the SixtyFourBits() decision could be made once. This is a bit harder
than I
thought due to a lot of shared code and the way the Visit* functions work.
My next approach has been putting the branch only once in the Visit*
functions
and then templatizing any helper functions that access the registers.
This however is a decent amount of code. Eventually the Set/Get size
functions
can be removed and only the fixed memcpy function will be necessary.
I could be wrong about why the other cl fails gcc under optimization and the
best approach could to just do the changes to SimRegisterBase. It would be
a
lot less code. Part of that depends on changing value_ from an array to a
single entity.
https://codereview.chromium.org/213943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
