2 tiny drive-by comments...
https://codereview.chromium.org/213943002/diff/80001/src/arm64/simulator-arm64.cc
File src/arm64/simulator-arm64.cc (right):
https://codereview.chromium.org/213943002/diff/80001/src/arm64/simulator-arm64.cc#newcode888
src/arm64/simulator-arm64.cc:888: public:
On 2014/05/16 18:11:46, Fritz wrote:
On 2014/05/16 14:05:50, jbramley wrote:
> Is 'public' necessary here?
Yes. Below it is accessed make_unsigned<T>::type
Huh? struct = class + public, so this shouldn't be needed, unless there
is some arcane template/namespace/overloading/... resolution rule which
I don't know. :-)
https://codereview.chromium.org/213943002/diff/80001/src/arm64/simulator-arm64.cc#newcode1934
src/arm64/simulator-arm64.cc:1934: const T kMinimumInteger =
static_cast<T>(1) << (sizeof(T) * 8 - 1);
Even better idea: Use <limits>:
http://www.cplusplus.com/reference/limits/numeric_limits/
https://codereview.chromium.org/213943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
