https://codereview.chromium.org/213943002/diff/120001/src/arm64/simulator-arm64.h
File src/arm64/simulator-arm64.h (right):
https://codereview.chromium.org/213943002/diff/120001/src/arm64/simulator-arm64.h#newcode76
src/arm64/simulator-arm64.h:76: template<typename T>
On 2014/05/20 19:44:24, Fritz wrote:
utils-arm64.h or utils.h?
It's not ARM64-specific, so I'd say utils.h, but there may be
conventions about these headers that I'm not aware of.
The specialisations in simulator-arm64.cc should be there too.
Finally, could you add a comment saying that this is like C++11's
`std::make_unsigned` please?
https://codereview.chromium.org/213943002/diff/120001/src/arm64/simulator-arm64.h#newcode159
src/arm64/simulator-arm64.h:159: int64_t value_;
On 2014/05/20 19:44:24, Fritz wrote:
for the SIMD registers I considered templating this class so that this
could be
a uint64_t or a uint128_t.
Is that acceptable?
I don't think we can assume that uint128_t is available. However, this
should probably work if we pass in a struct of two uint64_t values; you
can still memcpy its data. The initialisation list would need updating
but that's a problem we can deal with later.
https://codereview.chromium.org/213943002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
