On Thu, 7 May 2026 21:39:14 GMT, Coleen Phillimore <[email protected]> wrote:
>> Add a bunch of stubs and parameter changes to get non-Oracle platforms to >> compile. Tested with cross compilation in mach5. Also enabled GHA for >> these platforms. Tested tier1 with Oracle platforms. >> >> Porters please let me know if this runs hello world, then the rest is up to >> you. >> Thank you! >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Coleen Phillimore has updated the pull request incrementally with two > additional commits since the last revision: > > - include another file. > - Some forward declarations might do the trick. Marked as reviewed by dlong (no project role). src/hotspot/share/classfile/classFileParser.cpp line 5369: > 5367: // Leaving the mask and offset to default values (that is just > "return;") is a correct and easy way to implement > 5368: // this for other endianness, but it will have a runtime cost in > do_acmp, without the benefit. It is better, and > 5369: // probably easy with access to such an architecture, to adapt the > logic above Suggestion: // probably easy with access to such an architecture, to adapt the logic below ------------- PR Review: https://git.openjdk.org/valhalla/pull/2396#pullrequestreview-4250284701 PR Review Comment: https://git.openjdk.org/valhalla/pull/2396#discussion_r3206954724
