On Thursday 27 May 2004 04:26 am, Tonix wrote:
*ahem*
+#include <stdio.h>
*ahem*
If you comment out this line, you have this compilation error:
In file included from qmail-smtpd.c:45: /vpopmail/include/vpopmail.h:133: syntax error before `*'
This is the guilty 133 line, inside vpopmail.h:
struct vqpasswd *vgetent(FILE *);It looks like my patch needs stdio.h only because vpopmail needs it.
So, does Ken know your opinion about his writing "UGLY" and "HORRIBLE" code with glibc-stuff inside?
*ahem*
> This patch is running in hundreds of productions sites since more than two > years (without a bug and without any performance problem), and I'm > receiving dozen of e-mails, each month, thanking for it.
I continually see reports of 'false positives' on this mailing list.
This is a MySQL fault, with vpopmail NOT handling bad return codes in some core routines.
I'll ask, nextly, to join the development group and develop a robust subset of calls solving this problem (for all, not only for chkuser).
Not to mention my first experience with this patch it wasn't even a unified diff, therefore I had to apply it against a fresh qmail tarball and make a real diff out of it before I could apply it against the qmail tarball I was building.
I'm not selling this patch, it is just a free patch.
And you should know about patching patched sources...
I don't like how it determines the 'catchall' either, however, that's not a problem with the patch, that's a problem with how vpopmail determines how it's supposed to handle deliveries to unknown user accounts/aliases.
Thanks.
Tonino
-Jeremy
-- Jeremy Kitchen ++ Systems Administrator ++ Inter7 Internet Technologies, Inc. [EMAIL PROTECTED] ++ www.inter7.com ++ 866.528.3530 ++ 847.492.0470 int'l kitchen @ #qmail #gentoo on EFnet ++ scriptkitchen.com/qmail
------------------------------------------------------------ [EMAIL PROTECTED] Interazioni di Antonio Nati http://www.interazioni.it [EMAIL PROTECTED] ------------------------------------------------------------
